Refactoring pii_redactor as its own dpk_ named module #895
Conversation
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
|
@SowmyaLR We are in the process of refactoring all the transforms code as named modules. Please take a look at how I did your code and provide comments/feedback/approval on the proposed changes. The intent is to simplify the structure so Transforms developer have fewer things to deal with and also so all the transforms can be packaged together as a single pypi. thanks |
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
|
@SowmyaLR Hope all is well. Are you in piosition to review, approve or provide comments on this PR ? Thanks |
|
Hi, @SowmyaLR When will you be able to review the restructured code? We are anxious to merge the new code after your review. |
|
LGTM, in all the source files only the import is changed. |
|
Thank you everyone for making this change @shahrokhDaijavad @touma-I @matouma |
That is correct. This is needed so each transform is in its own named module. |
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Why are these changes needed?
First pass at restructuring the transform built as its own module (e.g. dpk_pii_redactor) with a ray submodule (dpk_pii_redactor.ray ).
Removed python and ray folders and refactor Dockerfile.python and Dockerfile.ray
remove pyproject.toml and Makefiles
move python code under dpk_pii_redactor
move ray code under dpk_pii_redactor/ray
change import statement to include module name
replace recursive Makefile and use targets from .make.cicd.targets
adapt kfp_ray/Makefile and other make target
Related issue number (if any).
#774